thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikail Bagishov (JIRA)" <j...@apache.org>
Subject [jira] [Created] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes
Date Tue, 29 Jan 2019 18:19:00 GMT
Mikail Bagishov created THRIFT-4764:
---------------------------------------

             Summary: Rust frontend emits deprecated clippy suppression attributes
                 Key: THRIFT-4764
                 URL: https://issues.apache.org/jira/browse/THRIFT-4764
             Project: Thrift
          Issue Type: Improvement
          Components: Rust - Compiler
         Environment: Ubuntu Cosmic x64

Thrift from master
            Reporter: Mikail Bagishov


Currently, following lines are inserted:
{code:none}
#![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))]
{code}
But this syntax is deprecated now.

Following should be used instead:
{code:none}
#![allow(clippy::too_many_arguments, clippy::type_complexity)]
{code}
Note: I fixed this issue in my [fork|http://github.com/MikailBag/thrift], but I'm not sure
if it will be easier for developers to merge my PR than apply changes themselves. Also, I'm
student and my Git skills are not very good)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message