thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4758) We gitignore and do not check in config lock files in many languages - isn't that bad?
Date Fri, 25 Jan 2019 19:37:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III updated THRIFT-4758:
--------------------------------------
    Description: 
In npm we check in the package-lock.json file because that ensures your builds are stable
over time.  The cost you pay is that occasionally you need to rev the file manually.  The
benefit is a changed package won't bork your build.

I have identified in the following languages we are ignoring and not checking in the package
lock files:

d (dub)
dart
php (top level composer.jock)
ruby
rust

  was:
In npm we check in the package-lock.json file because that ensures your builds are stable
over time.  The cost you pay is that occasionally you need to rev the file manually.  The
benefit is a changed package won't bork your build.

I have identified in the following languages we are ignoring and not checking in the package
lock files:

dart
php (top level composer.jock)
ruby
rust


> We gitignore and do not check in config lock files in many languages - isn't that bad?
> --------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4758
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4758
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, D - Library, Dart - Library, PHP - Library, Ruby
- Library, Rust - Compiler
>    Affects Versions: 0.12.0
>            Reporter: James E. King III
>            Priority: Major
>
> In npm we check in the package-lock.json file because that ensures your builds are stable
over time.  The cost you pay is that occasionally you need to rev the file manually.  The
benefit is a changed package won't bork your build.
> I have identified in the following languages we are ignoring and not checking in the
package lock files:
> d (dub)
> dart
> php (top level composer.jock)
> ruby
> rust



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message