thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4514) Remove pthread and boost::thread library support and use std::thread for C++11
Date Sat, 05 Jan 2019 06:56:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III updated THRIFT-4514:
--------------------------------------
    Affects Version/s: 0.12.0

> Remove pthread and boost::thread library support and use std::thread for C++11
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-4514
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4514
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.11.0, 0.12.0
>            Reporter: James E. King III
>            Assignee: James E. King III
>            Priority: Major
>
> We have a pretty awful thread class implementation:
> 1. The build system compiles in the right files to implement the class definition.
>  2. We support three thread libraries.
> I want to simplify this, tremendously, to:
> A. Remove the pthread implementation.
>  B. Remove the boost thread implementation.
>  C. Rename the std thread implementation (StdThreadFactory) to ThreadFactory
>  D. Have one thread class implementation!
>  E. Remove the WITH_STDTHREADS build time option as it will no longer be necessary.
> In short:
>  * Support std::thread for C++11 or later
>  * Drop support for boost threads
>  * Drop support for native pthreads
> We have a lot of branches and test conditionals that do special things with different
thread implementations. We need to simplify and move forward to reduce the maintenance cost
in this area.
> Any objections?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message