thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Can Celasun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4453) Go generator flag to turn off Context parameter
Date Thu, 03 Jan 2019 15:13:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733137#comment-16733137
] 

Can Celasun commented on THRIFT-4453:
-------------------------------------

> For what it's worth, I don't believe it to be a minor few minutes change because this
has to be done on top of other breaking changes for 0.11.0 go code generation.

Yes, 0.11 had more BC breaks but this ticket is specifically about context support, which
does take a few minutes to update. I know because I did just that for a service with 100+
RPCs.

> I'm still not very certain of the value adding context to the RPC functions has had since
it was added a long time ago and as far as I can tell it's not used at all and can't seem
to find any real examples of the benefits.

Most importantly it provides cancellation support, but it's useful for passing transport related
information to the handlers, like client IP.

> Go generator flag to turn off Context parameter
> -----------------------------------------------
>
>                 Key: THRIFT-4453
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4453
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.11.0
>            Reporter: Renan DelValle
>            Priority: Minor
>
> It would be worthwhile to be able to pass a argument to the code generator for Go that
allows to disable the addition of the Context parameter to each function signature that was
included with the 0.11.0 release. This is to avoid backwards incompatible code generation
in cases where developers don't require context.
> This flag could be as simple as `-disable-context`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message