thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-4027) Compilation error with boost 1.63.0
Date Mon, 07 Jan 2019 13:21:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III resolved THRIFT-4027.
---------------------------------------
       Resolution: Fixed
         Assignee: James E. King III
    Fix Version/s: 0.11.0

I believe this was fixed in 0.11.0 by changing our macro to BOOST_VERSION.

> Compilation error with boost 1.63.0
> -----------------------------------
>
>                 Key: THRIFT-4027
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4027
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>    Affects Versions: 0.10.0
>         Environment: Boost 1.63.0
>            Reporter: Benoit Sigoure
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 0.11.0
>
>         Attachments: 1005-Workaround-for-Boost-1.63.0.patch
>
>
> It's kinda stupid but {{Boost.Test}} introduced a global variable called {{VERSION}}
in one of their inline headers ([in this commit|https://github.com/boostorg/test/commit/86bcffea6dfb2513142c42721bf2af3e80ea068d])
and this causes the build of Thrift 0.10.0 to fail with:
> {code}
> make[1]: Entering directory `/bld/thrift/Artools-rpmbuild/thrift-0.10.0/compiler/cpp/test'
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift -I../../../lib/c_glib/src/thrift
 -I/usr/include -I../../../compiler/cpp/src -I../../../lib/cpp/src -I../../../lib/cpp/src
 -Wall -Wextra -pedantic -O2 -g -pipe -Wall -Wp,-D
> _FORTIFY_SOURCE=2 -fexceptions -fstack-protector -fno-var-tracking -fno-var-tracking-assignments
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables  -std=c++11
-c -o plugin/conversion_test.o plugin/convers
> ion_test.cc
> In file included from /usr/include/boost/test/included/unit_test.hpp:32:0,
>                  from plugin/conversion_test.cc:28:
> /usr/include/boost/test/impl/unit_test_parameters.ipp:102:12: error: expected unqualified-id
before string constant
>  std::string VERSION           = "version";
>             ^
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message