thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-2863) byte data type is unsigned in generated Obj-C code
Date Mon, 14 Jan 2019 15:04:04 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III resolved THRIFT-2863.
---------------------------------------
       Resolution: Won't Do
         Assignee: James E. King III
    Fix Version/s: 1.0

As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all
of the issues in Jira related to that code have also been removed.  For legacy cocoa support
you can use version 0.12.0 - everyone is expected to move to swift if they want to use the
next release of Thrift.

> byte data type is unsigned in generated Obj-C code
> --------------------------------------------------
>
>                 Key: THRIFT-2863
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2863
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>    Affects Versions: 0.9.1
>         Environment: Using thrift compiled on Ubuntu:
> DISTRIB_ID=Ubuntu
> DISTRIB_RELEASE=12.04
> DISTRIB_CODENAME=precise
> DISTRIB_DESCRIPTION="Ubuntu 12.04.5 LTS"
> NAME="Ubuntu"
> VERSION="12.04.5 LTS, Precise Pangolin"
> ID=ubuntu
> ID_LIKE=debian
> PRETTY_NAME="Ubuntu precise (12.04.5 LTS)"
> VERSION_ID="12.04"
>            Reporter: Steve Yegge
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 1.0
>
>
> I have a Thrift struct:
> struct ObjectRecord {
>   1: byte viewXOffset,
>   2: byte viewYOffset,
> }
> The generated Java code looks like this:
>   public ObjectRecord(
>     byte viewXOffset,
>     byte viewYOffset) {...}
> The generated Objective C header looks like this:
> @interface ObjectRecord : NSObject <TBase, NSCoding> {
>   uint8_t __viewXOffset;
>   uint8_t __viewYOffset;
> }
> According to the docs (https://thrift.apache.org/docs/types), a Thrift byte is an 8-bit
signed integer.
> Can work around for now by converting back to signed after reading the value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message