thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <>
Subject [jira] [Commented] (THRIFT-2464) Transition cpp_type and cpp_include keywords to compiler annotations
Date Thu, 03 Jan 2019 20:25:00 GMT


James E. King III commented on THRIFT-2464:

This has the potential to lead to chaos.  What if someone chooses a type that does not meet
the requirements?  For example what if they use a std::multimap because they want to support
multiple values for the same key, and then they serialize that and send it to another language
that implements a map which only supports one value per key?  The result would be silent data

It would be better to declare a hashmap or a multimap core type and implement it across the
languages so this chaos is avoided.

> Transition cpp_type and cpp_include keywords to compiler annotations
> --------------------------------------------------------------------
>                 Key: THRIFT-2464
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9.2
>         Environment: C++
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
> The cpp_type and cpp_include keywords provide a useful feature but are language specific.
In keeping with the trend of moving the interface language to a clean cross implementation
language abstraction, these two keywords should be transitioned to annotations.

This message was sent by Atlassian JIRA

View raw message