thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Randy Abernethy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2242) Generate C++11 code
Date Mon, 07 Jan 2019 19:55:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736267#comment-16736267
] 

Randy Abernethy commented on THRIFT-2242:
-----------------------------------------

I just want to shout this loudly, Thrift Sets [at the IDL level] are unordered. You can implement
them in a server or client with ordered sets or unordered sets (in C++ using the hack James
mentions or with annotations in Java). However on the wire, you must not expect a set or map
to be ordered, only a list.

> Generate C++11 code
> -------------------
>
>                 Key: THRIFT-2242
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2242
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.1
>            Reporter: Vitali Lovich
>            Priority: Major
>
> unordered_map instead of map, unordered_set instead of set, noexcept instead of throw()
(unless the exact semantics of throw() are needed which seems unlikely).
> It should use the shared_ptr implementation that the library is configured with.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message