thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-1759) for generated Obj-C constants, move static variable declarations in implementation file to 'static const' declarations in header file
Date Mon, 14 Jan 2019 15:04:04 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III resolved THRIFT-1759.
---------------------------------------
       Resolution: Won't Do
         Assignee: James E. King III
    Fix Version/s: 1.0

As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all
of the issues in Jira related to that code have also been removed.  For legacy cocoa support
you can use version 0.12.0 - everyone is expected to move to swift if they want to use the
next release of Thrift.

> for generated Obj-C constants, move static variable declarations in implementation file
to 'static const' declarations in header file
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1759
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1759
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Compiler
>    Affects Versions: 0.1, 0.9, 1.0
>            Reporter: Paul Mans
>            Assignee: James E. King III
>            Priority: Minor
>             Fix For: 1.0
>
>         Attachments: t_cocoa_generator_const_static.patch
>
>
> By declaring constants as 'static const' in the header file instead in of the implementation
file we can use the constants in more places, such as in case statements of switch blocks.
 
> Currently in Obj-C constants can only be accessed by using the static methods, which
leads to some limitations.
> The 'const' prefix only should apply to "primitive" constants (not structs or collections)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message