thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-1430) Fixes for property warnings generated in struct headers
Date Mon, 14 Jan 2019 15:04:04 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III resolved THRIFT-1430.
---------------------------------------
       Resolution: Won't Do
         Assignee: James E. King III
    Fix Version/s: 1.0

As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all
of the issues in Jira related to that code have also been removed.  For legacy cocoa support
you can use version 0.12.0 - everyone is expected to move to swift if they want to use the
next release of Thrift.

> Fixes for property warnings generated in struct headers
> -------------------------------------------------------
>
>                 Key: THRIFT-1430
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1430
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Compiler
>    Affects Versions: 0.7
>            Reporter: Mike Riley
>            Assignee: James E. King III
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: thrift-1430.patch
>
>
> Every struct generates warnings in the header because the properties are declared twice,
once implicitly through the property declaration and once explicitly by the actual function
declarations. This was done to increase compatibility with older versions of objective c that
didn't have the ability to use the property syntax as it is declared now. This is harmless
but you get two warnings per struct member, and in my case that worked out to a few hundred
warnings.
> The fix here is a simple refactor for isSet method declaration, and placing the declaration
of the alternate getter/setter implementations into an #else statement beneath the currently
existing #if statement, as opposed to just declaring them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message