From dev-return-54106-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Dec 27 16:25:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DCB69180625 for ; Thu, 27 Dec 2018 16:25:26 +0100 (CET) Received: (qmail 97225 invoked by uid 500); 27 Dec 2018 15:25:25 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 97197 invoked by uid 99); 27 Dec 2018 15:25:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2018 15:25:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 743751804C9 for ; Thu, 27 Dec 2018 15:25:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id qs2O1IJSt4x6 for ; Thu, 27 Dec 2018 15:25:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BC9916115B for ; Thu, 27 Dec 2018 15:25:09 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 74F92E2635 for ; Thu, 27 Dec 2018 15:25:08 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5A1FA2535A for ; Thu, 27 Dec 2018 15:25:08 +0000 (UTC) Date: Thu, 27 Dec 2018 15:25:08 +0000 (UTC) From: "James E. King III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (THRIFT-4614) Generate missing @Nullable annotations for Java iterator getters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4614?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-4614. ------------------------------------- > Generate missing @Nullable annotations for Java iterator getters > ---------------------------------------------------------------- > > Key: THRIFT-4614 > URL: https://issues.apache.org/jira/browse/THRIFT-4614 > Project: Thrift > Issue Type: New Feature > Components: Java - Compiler > Reporter: Manu Sridharan > Priority: Major > Fix For: 0.12.0 > > > This is a brief follow-up to=C2=A0THRIFT-4530.=C2=A0 In that change, we n= eglected to generate `@Nullable` annotations for iterator=C2=A0getters for = sets and lists.=C2=A0 They can clearly return null; see=C2=A0[here|[https:/= /github.com/apache/thrift/blob/0a2d4587c8cc0a54e4fa8fee9247d088d05b0d65/com= piler/cpp/src/thrift/generate/t_java_generator.cc#L2367].]=C2=A0 The code c= hange is a one-liner.=C2=A0 Will open a GitHub PR with the change.=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)