thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
Date Fri, 07 Dec 2018 21:20:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III resolved THRIFT-4679.
---------------------------------------
       Resolution: Fixed
         Assignee: James E. King III
    Fix Version/s: 1.0

Committed - thanks!

> Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
> -------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4679
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4679
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.11.0
>            Reporter: Griffin Michl
>            Assignee: James E. King III
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 1.0
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> InputBufferUnderrunError is unnecessarily declared  twice in `lib/nodejs/lib/thrift/json_protocol.js`.
This causes certain compilers to break when they attempt to compile code that uses the node
thrift library. We should remove the first declaration, as it does not do anything.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message