thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "yuanyuan chen (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4678) add noexcept cpp generator option
Date Thu, 20 Dec 2018 07:38:00 GMT


yuanyuan chen commented on THRIFT-4678:

[~jking3] Do the community have a clear roadmap to switch to C++11? By the way,there is no
a new thrift release since Dec 4, 2017. I would want to change cmake files and runtime library
to check that if compiler version supports C++11,then drop Boost code completely,but I don't
want to make useless effort that can't be merge into master. So give me a plan.

> add noexcept cpp generator option
> ---------------------------------
>                 Key: THRIFT-4678
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.11.0
>            Reporter: yuanyuan chen
>            Priority: Minor
> The C++11 standard has deprecated the usage of throw() to express exceptions,so to avoid
warnings from the compiler,I think this option is useful.
> I have a pull request in github,this issue is created to track it.
> Some questions remain:
> 1.Should we change the runtime c++ library to use BOOST_NOEXCEPT_OR_NOTHROW?
> 2.Should we add an control option to enable all c++11 options like moveable_types .etc?
> 3.Should we begin to support C+17 features? I think std::optional should be used to implement
optional keyword,but this is clearly an API breaking change,so we need an c+17 control option.

This message was sent by Atlassian JIRA

View raw message