From dev-return-53726-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Sat Nov 10 16:33:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3E3CF18067A for ; Sat, 10 Nov 2018 16:33:05 +0100 (CET) Received: (qmail 54186 invoked by uid 500); 10 Nov 2018 15:33:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 54172 invoked by uid 99); 10 Nov 2018 15:33:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Nov 2018 15:33:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9BFE9CC0B8 for ; Sat, 10 Nov 2018 15:33:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id L1AvEqWwBH8f for ; Sat, 10 Nov 2018 15:33:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7416962381 for ; Sat, 10 Nov 2018 15:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0B1EE02ED for ; Sat, 10 Nov 2018 15:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5EA13266E1 for ; Sat, 10 Nov 2018 15:33:00 +0000 (UTC) Date: Sat, 10 Nov 2018 15:33:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4662) Rust const string calls function at compile time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4662?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166= 82465#comment-16682465 ]=20 ASF GitHub Bot commented on THRIFT-4662: ---------------------------------------- allengeorge commented on a change in pull request #1624: THRIFT-4662: Rust = const string calls function at compile time URL: https://github.com/apache/thrift/pull/1624#discussion_r232455341 =20 =20 ########## File path: compiler/cpp/src/thrift/generate/t_rs_generator.cc ########## @@ -414,6 +414,9 @@ class t_rs_generator : public t_generator { // Return a string representing the rift `protocol::TType` given a `t_ty= pe`. string to_rust_field_type_enum(t_type* ttype); =20 + // Return a string representing the `const` rust type given a `t_type` + string to_rust_const_type(t_type* ttype, bool ordered_float =3D true); =20 Review comment: Good call. Makes sense to split this out from the `to_rust_type`. Could = you please put this function declaration right before `to_rust_type`? And d= o the same for implementation please? It just ensures that code that has si= milar functionality is in the same part of the file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Rust const string calls function at compile time > ------------------------------------------------ > > Key: THRIFT-4662 > URL: https://issues.apache.org/jira/browse/THRIFT-4662 > Project: Thrift > Issue Type: Bug > Components: Rust - Compiler > Affects Versions: 0.11.0 > Environment: C:\Users\jake>rustup show > Default host: x86_64-pc-windows-msvc > stable-x86_64-pc-windows-msvc (default) > rustc 1.30.0 (da5f414c2 2018-10-24) > Reporter: J W > Assignee: Allen George > Priority: Major > > *For this thrift:* > const string broker_playback_message =3D "mmi.developer.playback" > *Generates:* > // thrift -gen rs -out ../rust/thrift/src const_string.thrift > pub const BROKER_PLAYBACK_MESSAGE: String =3D "mmi.developer.playback".to= _owned(); > *Fails to compile:* > error[E0015]: calls in constants are limited to tuple structs and tuple v= ariants > note: a limited form of compile-time function evaluation is available on = a nightly compiler via `const fn` > *Fix:* > Probably want to output: > pub const BROKER_PLAYBACK_MESSAGE: &str =3D "mmi.developer.playback"; > =C2=A0 > Looking at render_const_value() it looks like byte arrays will have the s= ame issue. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)