thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4656) infinite loop in latest PHP library
Date Sun, 11 Nov 2018 15:57:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682916#comment-16682916
] 

ASF GitHub Bot commented on THRIFT-4656:
----------------------------------------

jeking3 commented on issue #1618: THRIFT-4656: Fix infinite loop in PHP TCurlClient
URL: https://github.com/apache/thrift/pull/1618#issuecomment-437681718
 
 
   Sounds like an improvement, but here's the issue I think exists with oneway:
   
   1. Generated client code sends a oneway request.
   2. HTTP transport packages it up and send it to the server.  This could be through a proxy.
   3. Server receives it.  Since it is a oneway request, my assumption is the server, no matter
what the language, has a HTTP transport that issues a response (like 200 OK without content,
or 204 as you stated).  If it did not, it wouldn't work through a proxy (or at least, the
proxy might behave badly).
   An example of this can be found at https://github.com/apache/thrift/blob/master/lib/py/src/server/THttpServer.py#L86.
   4. Client has no generated response reader code because it is oneway, so the client code
never attempts to get the transport response (which is fair, oneway probably came around before
we had a transport with a mandatory response).  However now there's a transport reply sitting
in the buffer.
   5. The next request sent by the client that is normal (not oneway) would send the request
and then read the HTTP 1.1 200 OK response buffered from from the oneway request, and the
actual reply to the two-way request would get queued up; however the response processor for
the twoway request, seeing no payload, would throw an exception.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> infinite loop in latest PHP library
> -----------------------------------
>
>                 Key: THRIFT-4656
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4656
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>            Reporter: Josip Sokcevic
>            Priority: Major
>             Fix For: 0.12.0
>
>         Attachments: 0001-THRIFT-4656-Fix-infinite-loop-in-PHP-TCurlClient.patch
>
>
> The latest PHP library can enter into infinite loop state when specific payload is returned:
> HTTP status: 200
> Response body: <empty>
>  
> It was introduced with THRIFT-4645, where check was replaced from
> {code:java}
> !$this->response_{code}
> to
> {code:java}
> $this->response_ === false{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message