thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4656) infinite loop in latest PHP library
Date Sun, 11 Nov 2018 15:34:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682908#comment-16682908
] 

ASF GitHub Bot commented on THRIFT-4656:
----------------------------------------

allengeorge commented on issue #1618: THRIFT-4656: Fix infinite loop in PHP TCurlClient
URL: https://github.com/apache/thrift/pull/1618#issuecomment-437680054
 
 
   Would it be better for the language runtime to return a `204` indicating a successful request
but no content?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> infinite loop in latest PHP library
> -----------------------------------
>
>                 Key: THRIFT-4656
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4656
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>            Reporter: Josip Sokcevic
>            Priority: Major
>             Fix For: 0.12.0
>
>         Attachments: 0001-THRIFT-4656-Fix-infinite-loop-in-PHP-TCurlClient.patch
>
>
> The latest PHP library can enter into infinite loop state when specific payload is returned:
> HTTP status: 200
> Response body: <empty>
>  
> It was introduced with THRIFT-4645, where check was replaced from
> {code:java}
> !$this->response_{code}
> to
> {code:java}
> $this->response_ === false{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message