thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines
Date Mon, 12 Nov 2018 11:57:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683662#comment-16683662
] 

ASF GitHub Bot commented on THRIFT-4529:
----------------------------------------

allengeorge commented on issue #1625: THRIFT-4529: Rust enum variants are now camel-cased
URL: https://github.com/apache/thrift/pull/1625#issuecomment-437853453
 
 
   @jeking3 I've made the requested changes, and, the only thing that fails in Travis is the
SBCL build under autotools :/ Could this be merged please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rust generation should include #![allow(non_snake_case)] or force conform to Rust style
guidelines
> --------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4529
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4529
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Rust - Compiler
>    Affects Versions: 0.11.0
>            Reporter: Joshua
>            Assignee: Allen George
>            Priority: Minor
>
> Without this, building a project using a thrift file meant for multiple languages may
end up with many compiler warnings similar to the following:
> {code:sh}
> warning: variant `EXAMPLE_NAME` should have a camel case name such as `ExampleName`
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message