thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3143) add typescript directory support
Date Mon, 26 Nov 2018 08:02:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698592#comment-16698592
] 

ASF GitHub Bot commented on THRIFT-3143:
----------------------------------------

mustafa-cosar edited a comment on issue #1630: THRIFT-3143: Add nodets support
URL: https://github.com/apache/thrift/pull/1630#issuecomment-441549384
 
 
   OK, I tried locally with `cpp,java,nodejs` servers and clients. 
   
   The cross tests with above languages passed. 
   
   @jeking3 If there is no other failure, can we merge this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> add typescript directory support
> --------------------------------
>
>                 Key: THRIFT-3143
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3143
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Node.js - Compiler
>            Reporter: Kazuki Yasufuku
>            Priority: Major
>
> Current typescript support is only work for browser, and generated d.ts uses internal
module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message