From dev-return-53616-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Oct 22 20:38:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 70F9018064A for ; Mon, 22 Oct 2018 20:38:06 +0200 (CEST) Received: (qmail 98454 invoked by uid 500); 22 Oct 2018 18:38:05 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 98443 invoked by uid 99); 22 Oct 2018 18:38:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 18:38:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0F239180724 for ; Mon, 22 Oct 2018 18:38:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 58Yl5HXKEsWO for ; Mon, 22 Oct 2018 18:38:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55AEF5F188 for ; Mon, 22 Oct 2018 18:38:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3F33BE0E1D for ; Mon, 22 Oct 2018 18:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9F036252B1 for ; Mon, 22 Oct 2018 18:38:00 +0000 (UTC) Date: Mon, 22 Oct 2018 18:38:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4653) ES6 Classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659337#comment-16659337 ] ASF GitHub Bot commented on THRIFT-4653: ---------------------------------------- bforbis removed a comment on issue #1615: THRIFT-4653: ES6 classes support URL: https://github.com/apache/thrift/pull/1615#issuecomment-431741676 The last commit I made somehow didn't make it to this PR, so I am going to try re-opening. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > ES6 Classes > ----------- > > Key: THRIFT-4653 > URL: https://issues.apache.org/jira/browse/THRIFT-4653 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Compiler, Node.js - Compiler > Reporter: Brian Forbis > Priority: Minor > > Updating the generated code to generate ES6 classes when using the es6 compiler option. ES6 classes should be a drop in replacement for manual ES5 prototypical inheritance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)