From dev-return-53578-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Wed Oct 17 15:41:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26EBB180674 for ; Wed, 17 Oct 2018 15:41:02 +0200 (CEST) Received: (qmail 90714 invoked by uid 500); 17 Oct 2018 13:41:02 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 90692 invoked by uid 99); 17 Oct 2018 13:41:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Oct 2018 13:41:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ACFA6C8562 for ; Wed, 17 Oct 2018 13:41:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id R8F6r-c4s8Dd for ; Wed, 17 Oct 2018 13:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E3D0D5F432 for ; Wed, 17 Oct 2018 13:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 87BE6E25B0 for ; Wed, 17 Oct 2018 13:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3053F2123B for ; Wed, 17 Oct 2018 13:41:00 +0000 (UTC) Date: Wed, 17 Oct 2018 13:41:00 +0000 (UTC) From: "James E. King III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-4652) Invalid Go source for Services MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4652?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4652: -------------------------------------- Issue Type: Documentation (was: Wish) > Invalid Go source for Services > ------------------------------ > > Key: THRIFT-4652 > URL: https://issues.apache.org/jira/browse/THRIFT-4652 > Project: Thrift > Issue Type: Documentation > Components: Go - Library, Website > Affects Versions: 0.11.0 > Environment: macOS 10.14=C2=A0 > Go 1.11.1 darwin/amd64 > Thrift 0.11.0 > =C2=A0 > =C2=A0 > Reporter: Tristian Azura > Priority: Minor > > The Go compiler generates invalid code for=C2=A0Thrift services, more spe= cifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing t= he `context.Context` argument: > {noformat} > edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush > have () > want (context.Context) > edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush > have () > want (context.Context){noformat} > =C2=A0 > I used the following models: > =C2=A0* [https://github.com/evernote/evernote-thrift] > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)