thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2
Date Mon, 22 Oct 2018 22:16:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659758#comment-16659758
] 

ASF GitHub Bot commented on THRIFT-4654:
----------------------------------------

robbecker-wf commented on issue #1617: THRIFT-4654 Minor fixes for dart 1 & 2 compatibility
(backwards compatible)
URL: https://github.com/apache/thrift/pull/1617#issuecomment-432010016
 
 
   @jeking3 What's the next step? If we're ready to merge, do I need to squash commits?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Thrift Dart port is not compatible with Dart 2
> ----------------------------------------------
>
>                 Key: THRIFT-4654
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4654
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Dart - Library
>         Environment: Any OS, under Dart 2+
>            Reporter: Rob Becker
>            Assignee: James E. King III
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It is not possible to use the Dart thrift code under Dart 2. Dart 2 requires opting in
via a setting in the pubspec.yaml and the code needs to update the use of all caps constant
names to the new camel case names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message