thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4653) ES6 Classes
Date Thu, 18 Oct 2018 12:24:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655157#comment-16655157
] 

ASF GitHub Bot commented on THRIFT-4653:
----------------------------------------

jeking3 edited a comment on issue #1615: THRIFT-4653: ES6 classes support
URL: https://github.com/apache/thrift/pull/1615#issuecomment-430987795
 
 
   According to jshint there could be some issues in this... however I didn't test without
es6 to establish a baseline.  That said, perhaps we should be adding jshint to the build and
verifying it runs clean for both es6 and without.
   
   ```
   root@04cbb51176b6:/thrift/src/test# ../compiler/cpp/thrift --gen js:es6 EnumTest.thrift
   
   root@04cbb51176b6:/thrift/src# ./lib/js/node_modules/.bin/jshint test/gen-js/EnumTestService.js

   test/gen-js/EnumTestService.js: line 61, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 113, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 180, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 247, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 314, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 381, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 456, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 531, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 584, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 637, col 2, Missing semicolon.
   test/gen-js/EnumTestService.js: line 924, col 2, Missing semicolon.
   
   root@04cbb51176b6:/thrift/src# ./lib/js/node_modules/.bin/jshint test/gen-js/EnumTest_types.js
 
   test/gen-js/EnumTest_types.js: line 130, col 2, Missing semicolon.
   test/gen-js/EnumTest_types.js: line 620, col 2, Missing semicolon.
   test/gen-js/EnumTest_types.js: line 633, col 5, Expected '}' to match '{' from line 632
and instead saw '-'.
   test/gen-js/EnumTest_types.js: line 633, col 6, Expected '}' to match '{' from line 621
and instead saw '1'.
   test/gen-js/EnumTest_types.js: line 633, col 8, Expected ')' and instead saw ':'.
   test/gen-js/EnumTest_types.js: line 633, col 9, Missing semicolon.
   test/gen-js/EnumTest_types.js: line 634, col 7, Expected an assignment or function call
and instead saw an expression.
   test/gen-js/EnumTest_types.js: line 634, col 8, Missing semicolon.
   test/gen-js/EnumTest_types.js: line 634, col 9, Expected '}' to match '{' from line 633
and instead saw ':'.
   test/gen-js/EnumTest_types.js: line 634, col 11, Expected an assignment or function call
and instead saw an expression.
   test/gen-js/EnumTest_types.js: line 634, col 12, Missing semicolon.
   test/gen-js/EnumTest_types.js: line 634, col 11, Unrecoverable syntax error. (96% scanned).
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ES6 Classes
> -----------
>
>                 Key: THRIFT-4653
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4653
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Compiler, Node.js - Compiler
>            Reporter: Brian Forbis
>            Priority: Minor
>
> Updating the generated code to generate ES6 classes when using the es6 compiler option.
ES6 classes should be a drop in replacement for manual ES5 prototypical inheritance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message