thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4652) Invalid Go source for Services
Date Wed, 17 Oct 2018 13:18:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653528#comment-16653528
] 

ASF GitHub Bot commented on THRIFT-4652:
----------------------------------------

jeking3 commented on issue #1612: THRIFT-4652: Replace git.apache.org imports with github.com
URL: https://github.com/apache/thrift/pull/1612#issuecomment-430624283
 
 
   Apologies!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Invalid Go source for Services
> ------------------------------
>
>                 Key: THRIFT-4652
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4652
>             Project: Thrift
>          Issue Type: Wish
>          Components: Go - Compiler
>    Affects Versions: 0.11.0
>         Environment: macOS 10.14 
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>  
>  
>            Reporter: Tristian Azura
>            Priority: Minor
>
> The Go compiler generates invalid code for Thrift services, more specifically, calls
to the `thrift.TProtocol`'s `Flush()` method are missing the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>  
> I used the following models:
>  * [https://github.com/evernote/evernote-thrift]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message