thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tristian Azura (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4652) Invalid Go source for Services
Date Wed, 17 Oct 2018 07:56:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653152#comment-16653152
] 

Tristian Azura commented on THRIFT-4652:
----------------------------------------

Thank you!, that worked!

I think the Go documentation is a bit outdate and the links to source code are mostly dead.

I'd be happy to help update the Go tutorial docs, do you happen to know where the source for
the website documentation is?

Best, Tristian


> Invalid Go source for Services
> ------------------------------
>
>                 Key: THRIFT-4652
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4652
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>    Affects Versions: 0.11.0
>         Environment: macOS 10.14 
> Go 1.11.1 darwin/amd64
> Thrift 0.11.0
>  
>  
>            Reporter: Tristian Azura
>            Priority: Major
>
> The Go compiler generates invalid code for Thrift services, more specifically, calls
to the `thrift.TProtocol`'s `Flush()` method are missing the `context.Context` argument:
> {noformat}
> edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context)
> edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
> have ()
> want (context.Context){noformat}
>  
> I used the following models:
>  * [https://github.com/evernote/evernote-thrift]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message