thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4644) Compiler cannot be compiled on macOS(maybe also on other platforms with clang)
Date Wed, 03 Oct 2018 11:58:00 GMT


ASF GitHub Bot commented on THRIFT-4644:

jeking3 closed pull request #1601: THRIFT-4644: Compiler cannot be compiled on macOS

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/compiler/cpp/src/thrift/generate/ b/compiler/cpp/src/thrift/generate/
index 93ba3d0ecf..9c82b6cf2a 100644
--- a/compiler/cpp/src/thrift/generate/
+++ b/compiler/cpp/src/thrift/generate/
@@ -335,7 +335,7 @@ class t_py_generator : public t_generator {
   std::string module_;
-  virtual std::set<std::string> lang_keywords() {
+  virtual std::set<std::string> lang_keywords() const {
     std::string keywords[] = { "False", "None", "True", "and", "as", "assert", "break", "class",
           "continue", "def", "del", "elif", "else", "except", "exec", "finally", "for", "from",
           "global", "if", "import", "in", "is", "lambda", "nonlocal", "not", "or", "pass",


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Compiler cannot be compiled on macOS(maybe also on other platforms with clang)
> ------------------------------------------------------------------------------
>                 Key: THRIFT-4644
>                 URL:
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>    Affects Versions: 0.12.0
>         Environment: macOS High Sierra 10.13.5
> Apple LLVM version 9.0.0 (clang-900.0.39.2)
>            Reporter: Tsuzuki Tsuchiya
>            Priority: Critical
>             Fix For: 0.12.0
> I tried to compile the thrift compiler of [014f53f|]
on macOS, but I could not.
> This is an error message I got.
> *src/thrift/generate/* *error:* *'t_py_generator::lang_keywords'
hides overloaded virtual function [-Werror,-Woverloaded-virtual]*
>   std::set<std::string> lang_keywords() {
>                         *^*
> *./src/thrift/generate/t_generator.h:106:33: note:* hidden overloaded virtual function
't_generator::lang_keywords' declared here: different qualifiers (const vs none)
>   virtual std::set<std::string> lang_keywords() const;
>                                 *^*
> 1 error generated.

This message was sent by Atlassian JIRA

View raw message