thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naveen Gangam (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4499) Remove Magic Number In TFIleTransport
Date Fri, 05 Oct 2018 17:17:00 GMT


Naveen Gangam commented on THRIFT-4499:

[~jking3] I have created a pull request for the proposed change (apologize for the bad description,
I did not realize it would post the default text). Could you review when you get a chance?

I have a question on an unrelated topic. Apache Hive uses thrift for both HiveServer2 service
and Hive Metastore Server (separate java processes that are both thrift-enabled services).
I am looking for means to inject some context into every thrift request to the HMS Server,
that could be retrieved and logged on the HMS side. This enables us to co-relate the query
on the hiveserver side with the metadata requests on the HMS side. For example, I could pass
in a string query ID from HS2 to HMS and print that id on HMS logs.

I am looking to accomplish this without having to change the existing thrift service APIs.
I dont want to change every API to take an additional argument. Does thrift currently have
any provision for this? Any help greatly appreciated. Thank you

> Remove Magic Number In TFIleTransport
> -------------------------------------
>                 Key: THRIFT-4499
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.11.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: THRIFT-4499.1.patch
> Here, the buffer is hard-coded to 8192 (which matches the default value on most JDK implementations).
You may wish to remove this magic number and let the JDK decide the size.

This message was sent by Atlassian JIRA

View raw message