thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4600) Don't close the connection in flush for python THttpClient.py
Date Fri, 14 Sep 2018 12:03:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614701#comment-16614701
] 

ASF GitHub Bot commented on THRIFT-4600:
----------------------------------------

jeking3 commented on issue #1572: THRIFT-4600: fix-flush-on-THttpClient
URL: https://github.com/apache/thrift/pull/1572#issuecomment-421337344
 
 
   @finncolman will you be able to resolve the new build failures?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Don't close the connection in flush for python THttpClient.py
> -------------------------------------------------------------
>
>                 Key: THRIFT-4600
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4600
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.11.0
>            Reporter: Finn Isaac Norris Colman
>            Priority: Major
>             Fix For: 0.11.0
>
>         Attachments: 1572.patch
>
>
> In thrift/lib/py/src/transport/THttpClient.py in the flush method it closes and reopens
the connection:
> {noformat}
> if self.isOpen():
>     self.close()
> self.open(){noformat}
>  
> This code is closing the connection on every flush request. The flush request occurs
for every message send, which means that keep alive cannot be used. Removing this code from
flush means that keep alive can be used as the user now has control over when the connection
is closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message