thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Can Celasun (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-4614) Generate missing @Nullable annotations for Java iterator getters
Date Tue, 07 Aug 2018 05:42:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Can Celasun resolved THRIFT-4614.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.12.0

> Generate missing @Nullable annotations for Java iterator getters
> ----------------------------------------------------------------
>
>                 Key: THRIFT-4614
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4614
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Compiler
>            Reporter: Manu Sridharan
>            Priority: Major
>             Fix For: 0.12.0
>
>
> This is a brief follow-up to THRIFT-4530.  In that change, we neglected to generate
`@Nullable` annotations for iterator getters for sets and lists.  They can clearly return
null; see [here|[https://github.com/apache/thrift/blob/0a2d4587c8cc0a54e4fa8fee9247d088d05b0d65/compiler/cpp/src/thrift/generate/t_java_generator.cc#L2367].] 
The code change is a one-liner.  Will open a GitHub PR with the change. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message