thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manu Sridharan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4614) Generate missing @Nullable annotations for Java iterator getters
Date Mon, 06 Aug 2018 23:56:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570935#comment-16570935
] 

Manu Sridharan commented on THRIFT-4614:
----------------------------------------

Pull request: https://github.com/apache/thrift/pull/1577

> Generate missing @Nullable annotations for Java iterator getters
> ----------------------------------------------------------------
>
>                 Key: THRIFT-4614
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4614
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Compiler
>            Reporter: Manu Sridharan
>            Priority: Major
>
> This is a brief follow-up to THRIFT-4530.  In that change, we neglected to generate
`@Nullable` annotations for iterator getters for sets and lists.  They can clearly return
null; see [here|[https://github.com/apache/thrift/blob/0a2d4587c8cc0a54e4fa8fee9247d088d05b0d65/compiler/cpp/src/thrift/generate/t_java_generator.cc#L2367].] 
The code change is a one-liner.  Will open a GitHub PR with the change. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message