thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4609) keep InnerException wherever appropriate
Date Fri, 03 Aug 2018 10:56:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568097#comment-16568097
] 

James E. King III commented on THRIFT-4609:
-------------------------------------------

Passing an InnerException back through to the client (through TApplicationException) would
be a security violation as the stack of the server would be exposed.  There should be no plan
to add that, but I agree with the remainder of the exception handling within the server or
client.

> keep InnerException wherever appropriate 
> -----------------------------------------
>
>                 Key: THRIFT-4609
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4609
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>
> The C# {{Exception}} type offers the ability to store an {{InnerException}} which is
sometimes quite helpful for debugging. Hence, wherever appropriate, any exceptions caught
and rethrown should be stored into the {{InnerException}} field to provide the original error
information to the caller.
> The only exception (pun intended) to this is {{TApplicationException}} - this type is
intended to be serialized and sent back to the client. As of today, Thrift does not any built-in
way to preserve InnerExceptions through that channnel.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message