thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Emmenlauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-1834) As a developer, I would like a thrift C++ runtime DLL for windows development
Date Wed, 29 Aug 2018 12:15:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596252#comment-16596252
] 

Mario Emmenlauer commented on THRIFT-1834:
------------------------------------------

Ok I will provide a PR againstĀ HEAD(?) to allow a cmake shared library build on Windows,
and instruct cmake to export all symbols on Windows.

Could you check the thrift compiler what symbols need to be exported? Is it just the class
definitions? Then we could pragmatically always export the full class. OrĀ are there other
interfaces (public variables or something)?

> As a developer, I would like a thrift C++ runtime DLL for windows development
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-1834
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1834
>             Project: Thrift
>          Issue Type: Story
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: Windows x86_64 MSVC 2010
>            Reporter: Chris Stylianou
>            Priority: Major
>              Labels: dll, msvc, thrift, windows
>
> I am unable to build a valid .dll version of the Thrift C++ library using MSVC2010 as
nothing has been declared with "__declspec(dllexport)/__declspec(dllimport)", meaning that
MSVC2010 (and presumably all other versions) are unable to generate the import .lib that should
accompany the .dll library.
> Currently the cmake environment only supports building a static library (with static
or dynamic runtime - you choose with the "WITH_MT" option).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message