From dev-return-53018-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Jul 5 15:31:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6965B180657 for ; Thu, 5 Jul 2018 15:31:03 +0200 (CEST) Received: (qmail 45656 invoked by uid 500); 5 Jul 2018 13:31:02 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 45645 invoked by uid 99); 5 Jul 2018 13:31:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jul 2018 13:31:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EFE6E182E86 for ; Thu, 5 Jul 2018 13:31:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id As8rGVlISYar for ; Thu, 5 Jul 2018 13:31:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2AED65F49F for ; Thu, 5 Jul 2018 13:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1B14E1095 for ; Thu, 5 Jul 2018 13:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6DBD427508 for ; Thu, 5 Jul 2018 13:31:00 +0000 (UTC) Date: Thu, 5 Jul 2018 13:31:00 +0000 (UTC) From: "James E. King III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-4591) lua client uses two write() calls per framed message send MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4591?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4591: -------------------------------------- Priority: Minor (was: Blocker) Component/s: (was: C++ - Library) Lua - Library Issue Type: Improvement (was: Bug) > lua client uses two write() calls per framed message send > --------------------------------------------------------- > > Key: THRIFT-4591 > URL: https://issues.apache.org/jira/browse/THRIFT-4591 > Project: Thrift > Issue Type: Improvement > Components: Lua - Library > Affects Versions: 0.11.0 > Reporter: allen_lee > Assignee: James E. King III > Priority: Minor > Attachments: 9090.pcap, 9090_1.pcap > > Original Estimate: 4h > Remaining Estimate: 4h > > 1) realize thrift server with TNonblockingServer via c++; > 2) realize thrift client via lua lib and choose frame transport. > 3) call remote interface failed with "TTransportException:0: Default (unk= nown)" print, and the server show "TConnection::workSocket(): THRIFT_EAGAIN= (unavailable resources)" error. > 4)investigate this fault with tcpdump tool, attachment 9090.pcap show the= frame msg doesnot contains frame size field, the rifht situation of attach= ment 9090_1.pcap show the frame msg contains 4 bytes (00 00 00 25) before p= rotocol id field. > 5) dig into the fault and tried to find root cause, then i found there is= an fault in TFramedTransport:flush function in TFramedTransport.lua file. = the original realization is: > ----- > function TFramedTransport:flush() > =C2=A0 if self.doWrite =3D=3D false then > =C2=A0=C2=A0=C2=A0 return self.trans:flush() > =C2=A0 end > =C2=A0 -- If the write fails we still want wBuf to be clear > =C2=A0 local tmp =3D self.wBuf > =C2=A0 self.wBuf =3D '' > =C2=A0 local frame_len_buf =3D libluabpack.bpack("i", string.len(tmp)) > =C2=A0 self.trans:write(frame_len_buf) > =C2=A0 self.trans:write(tmp) > =C2=A0 self.trans:flush() > end > ----- > which send frame size file and reset msg content independently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)