thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4303) D deprecation warnings
Date Tue, 05 Jun 2018 18:48:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III updated THRIFT-4303:
--------------------------------------
    Description: 
In the ubuntu 16.04 image dmd is version 2.075 and the following warnings are being presented
when building "make check":
{noformat}
../../lib/d/src/thrift/transport/socket.d(83): Deprecation: Implicit string concatenation
is deprecated, use "DMD bug? \u2013 Why would contracts work for interfaces, but not " ~ "for
abstract methods? " instead
../../lib/d/src/thrift/transport/socket.d(84): Deprecation: Implicit string concatenation
is deprecated, use "for abstract methods? " ~ "(Error: function [\u2026] in and out contracts
require function body" instead
src/thrift/protocol/json.d(29): Deprecation: function std.utf.toUTF8 is deprecated - To be
removed November 2017. Please use std.utf.encode instead.
src/thrift/transport/http.d(334): Deprecation: Implicit string concatenation is deprecated,
use "Accept: application/x-thrift\x0d\x0a" ~ "User-Agent: Thrift/" instead
{noformat}
I cleaned all but the UTF8 one up in this PR:

[https://github.com/apache/thrift/pull/1340/files]

 

In the ubuntu 18.04 image dmd is 2.077.1 and the following deprecations are present:

[https://api.travis-ci.org/v3/job/387336455/log.txt]
{noformat}
src/thrift/server/nonblocking.d(896): Deprecation: thrift.server.base.TServer.inputTransportFactory_
is not visible from module thrift.server.nonblocking
src/thrift/server/nonblocking.d(898): Deprecation: thrift.server.base.TServer.outputTransportFactory_
is not visible from module thrift.server.nonblocking
src/thrift/server/nonblocking.d(901): Deprecation: thrift.server.base.TServer.inputProtocolFactory_
is not visible from module thrift.server.nonblocking
src/thrift/server/nonblocking.d(903): Deprecation: thrift.server.base.TServer.outputProtocolFactory_
is not visible from module thrift.server.nonblocking
src/thrift/server/nonblocking.d(911): Deprecation: thrift.server.base.TServer.processorFactory_
is not visible from module thrift.server.nonblocking

thrift_test_client.d(128): Deprecation: struct std.datetime.StopWatch is deprecated
- Use std.datetime.stopwatch.StopWatch.
thrift_test_client.d(128): Deprecation: struct std.datetime.StopWatch is deprecated
- Use std.datetime.stopwatch.StopWatch.
thrift_test_client.d(338): Deprecation: struct std.datetime.StopWatch is deprecated
- Use std.datetime.stopwatch.StopWatch.
thrift_test_client.d(338): Deprecation: alias std.datetime.AutoStart is deprecated
- Use std.datetime.stopwatch.AutoStart.
thrift_test_client.d(338): Deprecation: struct std.datetime.StopWatch is deprecated
- Use std.datetime.stopwatch.StopWatch.{noformat}

  was:
In the ubuntu 16.04 image dmd is version 2.075 and the following warnings are being presented
when building "make check":
{noformat}
../../lib/d/src/thrift/transport/socket.d(83): Deprecation: Implicit string concatenation
is deprecated, use "DMD bug? \u2013 Why would contracts work for interfaces, but not " ~ "for
abstract methods? " instead
../../lib/d/src/thrift/transport/socket.d(84): Deprecation: Implicit string concatenation
is deprecated, use "for abstract methods? " ~ "(Error: function [\u2026] in and out contracts
require function body" instead
src/thrift/protocol/json.d(29): Deprecation: function std.utf.toUTF8 is deprecated - To be
removed November 2017. Please use std.utf.encode instead.
src/thrift/transport/http.d(334): Deprecation: Implicit string concatenation is deprecated,
use "Accept: application/x-thrift\x0d\x0a" ~ "User-Agent: Thrift/" instead
{noformat}
I cleaned all but the UTF8 one up in this PR:

[https://github.com/apache/thrift/pull/1340/files]


> D deprecation warnings
> ----------------------
>
>                 Key: THRIFT-4303
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4303
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>    Affects Versions: 0.10.0, 0.11.0
>         Environment: docker:ubuntu-xenial, docker:ubuntu-artful
>            Reporter: James E. King III
>            Priority: Minor
>
> In the ubuntu 16.04 image dmd is version 2.075 and the following warnings are being presented
when building "make check":
> {noformat}
> ../../lib/d/src/thrift/transport/socket.d(83): Deprecation: Implicit string concatenation
is deprecated, use "DMD bug? \u2013 Why would contracts work for interfaces, but not " ~ "for
abstract methods? " instead
> ../../lib/d/src/thrift/transport/socket.d(84): Deprecation: Implicit string concatenation
is deprecated, use "for abstract methods? " ~ "(Error: function [\u2026] in and out contracts
require function body" instead
> src/thrift/protocol/json.d(29): Deprecation: function std.utf.toUTF8 is deprecated -
To be removed November 2017. Please use std.utf.encode instead.
> src/thrift/transport/http.d(334): Deprecation: Implicit string concatenation is deprecated,
use "Accept: application/x-thrift\x0d\x0a" ~ "User-Agent: Thrift/" instead
> {noformat}
> I cleaned all but the UTF8 one up in this PR:
> [https://github.com/apache/thrift/pull/1340/files]
>  
> In the ubuntu 18.04 image dmd is 2.077.1 and the following deprecations are present:
> [https://api.travis-ci.org/v3/job/387336455/log.txt]
> {noformat}
> src/thrift/server/nonblocking.d(896): Deprecation: thrift.server.base.TServer.inputTransportFactory_
is not visible from module thrift.server.nonblocking
> src/thrift/server/nonblocking.d(898): Deprecation: thrift.server.base.TServer.outputTransportFactory_
is not visible from module thrift.server.nonblocking
> src/thrift/server/nonblocking.d(901): Deprecation: thrift.server.base.TServer.inputProtocolFactory_
is not visible from module thrift.server.nonblocking
> src/thrift/server/nonblocking.d(903): Deprecation: thrift.server.base.TServer.outputProtocolFactory_
is not visible from module thrift.server.nonblocking
> src/thrift/server/nonblocking.d(911): Deprecation: thrift.server.base.TServer.processorFactory_
is not visible from module thrift.server.nonblocking
> thrift_test_client.d(128): Deprecation: struct std.datetime.StopWatch is
deprecated - Use std.datetime.stopwatch.StopWatch.
> thrift_test_client.d(128): Deprecation: struct std.datetime.StopWatch is
deprecated - Use std.datetime.stopwatch.StopWatch.
> thrift_test_client.d(338): Deprecation: struct std.datetime.StopWatch is
deprecated - Use std.datetime.stopwatch.StopWatch.
> thrift_test_client.d(338): Deprecation: alias std.datetime.AutoStart is
deprecated - Use std.datetime.stopwatch.AutoStart.
> thrift_test_client.d(338): Deprecation: struct std.datetime.StopWatch is
deprecated - Use std.datetime.stopwatch.StopWatch.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message