thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4382) Replace the use of Perl Indirect Object Syntax calls to new()
Date Mon, 14 May 2018 13:25:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474200#comment-16474200
] 

ASF GitHub Bot commented on THRIFT-4382:
----------------------------------------

djzort commented on a change in pull request #1261: THRIFT-4382: Replace the use of Indirect
Object Syntax calls to new()
URL: https://github.com/apache/thrift/pull/1261#discussion_r187950898
 
 

 ##########
 File path: test/perl/TestServer.pl
 ##########
 @@ -48,7 +48,7 @@
 $|++;
 
 sub usage {
-    print <<EOF;
+    print <<"EOF";
 
 Review comment:
   See also core Perl::Critic policy http://search.cpan.org/dist/Perl-Critic/lib/Perl/Critic/Policy/ValuesAndExpressions/RequireQuotedHeredocTerminator.pm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace the use of Perl Indirect Object Syntax calls to new() 
> --------------------------------------------------------------
>
>                 Key: THRIFT-4382
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4382
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Perl - Compiler
>            Reporter: Dean Hamstead
>            Priority: Minor
>
> Using Indirect Object Syntax to instantiate objects is not recommended as per https://perldoc.perl.org/perlobj.html#Invoking-Class-Methods



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message