thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <>
Subject [jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
Date Wed, 02 May 2018 00:42:00 GMT


James E. King III commented on THRIFT-3769:

The project has not retroactively applied patches.  It will appear in 0.12.0 which is likely
to start soon, as we want to release more than once yearly :)  but in the meantime you can
maintain your own fork with the patch and build a jar...

> Fix logic of THRIFT-2268
> ------------------------
>                 Key: THRIFT-3769
>                 URL:
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.2
>            Reporter: Harsh J
>            Assignee: James E. King III
>            Priority: Minor
>             Fix For: 0.12.0
>         Attachments: THRIFT-3769.patch
> THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled servers, but
the commit doesn't help in doing so (its just adding more specific noise today).
> This is because the transport factory overrides disallow throwing specific execution
types (no TTransportException in signature), and thereby all implementations will throw a
RuntimeException-wrapped exception, which the added catch clauses would never encounter.
> We'll need to unwrap the RuntimeException to perform an actual valid cause check.

This message was sent by Atlassian JIRA

View raw message