From dev-return-52557-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Tue Apr 17 21:28:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8B8AC180649 for ; Tue, 17 Apr 2018 21:28:10 +0200 (CEST) Received: (qmail 75166 invoked by uid 500); 17 Apr 2018 19:28:09 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 75155 invoked by uid 99); 17 Apr 2018 19:28:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 19:28:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3435FC012D for ; Tue, 17 Apr 2018 19:28:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id UsZfXU2sR90Y for ; Tue, 17 Apr 2018 19:28:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3F9F25F126 for ; Tue, 17 Apr 2018 19:28:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AB6E1E0CB4 for ; Tue, 17 Apr 2018 19:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AD1BF241CA for ; Tue, 17 Apr 2018 19:28:00 +0000 (UTC) Date: Tue, 17 Apr 2018 19:28:00 +0000 (UTC) From: "Jens Geyer (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (THRIFT-4558) reserved Csharp keyword are not escaped when field is required MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4558: ---------------------------------- Assignee: Jens Geyer > reserved Csharp keyword are not escaped when field is required > -------------------------------------------------------------- > > Key: THRIFT-4558 > URL: https://issues.apache.org/jira/browse/THRIFT-4558 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler > Affects Versions: 0.9.3 > Reporter: Pierre Mignolet > Assignee: Jens Geyer > Priority: Blocker > Fix For: 0.9.3 > > > {code:java} > struct MeMessage { > 1: optional string fixed > 7: required string unchecked > }{code} > Here reserved fixed C# keyword is escaped via @ but unchecked is not escaped in C# code so code is just not compilable > ---- > I had a look in t_csharp_generator.cc and keyword are present and method normalize_name should make the escape -- This message was sent by Atlassian JIRA (v7.6.3#76005)