From dev-return-52529-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Apr 16 17:56:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A136D180608 for ; Mon, 16 Apr 2018 17:56:04 +0200 (CEST) Received: (qmail 74521 invoked by uid 500); 16 Apr 2018 15:56:03 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 74505 invoked by uid 99); 16 Apr 2018 15:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 15:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2794DC02CF for ; Mon, 16 Apr 2018 15:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ytDqFzmETUib for ; Mon, 16 Apr 2018 15:56:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0F1705FE1F for ; Mon, 16 Apr 2018 15:56:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 685ADE0CBE for ; Mon, 16 Apr 2018 15:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A2451241E0 for ; Mon, 16 Apr 2018 15:56:00 +0000 (UTC) Date: Mon, 16 Apr 2018 15:56:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4555?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 39622#comment-16439622 ]=20 ASF GitHub Bot commented on THRIFT-4555: ---------------------------------------- bpodgursky commented on issue #1540: THRIFT-4555 Optionally disable copies = of binary fields in Java constructors, getters, and setters URL: https://github.com/apache/thrift/pull/1540#issuecomment-381655186 =20 =20 Is there a way to force a rebuild? I'm unable to reproduce this error l= ocally, and that file is definitely in the PR. Maybe travis got confused b= y a rebase? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Getter of binary field in Java creates unnecessary copy > ------------------------------------------------------- > > Key: THRIFT-4555 > URL: https://issues.apache.org/jira/browse/THRIFT-4555 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Affects Versions: 0.11.0 > Reporter: Joel Croteau > Priority: Major > > The get[field] method in generated Java code generates a new copy of a bi= nary field every time it is called. This seems incredibly inefficient. Take= a simple example struct: > {code:java} > struct StructWithBinary { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1: required binary field; > } > {code} > a portion of the generated code for this is: > {code:java} > =C2=A0 public byte[] getField() { > =C2=A0=C2=A0=C2=A0 setField(org.apache.thrift.TBaseHelper.rightSize(field= )); > =C2=A0=C2=A0=C2=A0 return field =3D=3D null ? null : field.array(); > =C2=A0 } > ... > =C2=A0 public StructWithBinary setField(java.nio.ByteBuffer field) { > =C2=A0=C2=A0=C2=A0 this.field =3D org.apache.thrift.TBaseHelper.copyBinar= y(field); > =C2=A0=C2=A0=C2=A0 return this; > =C2=A0 } > {code} > So whenever getField is called, setField calls copyBinary and generates a= nother copy. This adds quite a lot of overhead to the getter here and shoul= d be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)