From dev-return-52520-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Apr 16 04:34:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B661F18067E for ; Mon, 16 Apr 2018 04:34:10 +0200 (CEST) Received: (qmail 84590 invoked by uid 500); 16 Apr 2018 02:34:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 84169 invoked by uid 99); 16 Apr 2018 02:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 02:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 79A3FC0E5E for ; Mon, 16 Apr 2018 02:34:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cdnR-IUOXxzU for ; Mon, 16 Apr 2018 02:34:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 86D3C5FD0D for ; Mon, 16 Apr 2018 02:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E334AE0361 for ; Mon, 16 Apr 2018 02:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69020241CF for ; Mon, 16 Apr 2018 02:34:00 +0000 (UTC) Date: Mon, 16 Apr 2018 02:34:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4532?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 38932#comment-16438932 ]=20 ASF GitHub Bot commented on THRIFT-4532: ---------------------------------------- jeking3 commented on issue #1541: THRIFT-4532: Do not update previously gen= erated output files if the contents have not changed URL: https://github.com/apache/thrift/pull/1541#issuecomment-381463350 =20 =20 Was it truly necessary to change the signature of the methods from ostre= am to ofstream? After all, an ofstream *is an* ostream. It should be poss= ible to keep all the methods using ostream which accepts your custom ofstre= am class that checks to see if the content changed. =20 Extra nice to see a test for this, by the way, I like that a lot! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Avoid updating Thrift compiler generated code if the output has not chang= ed > -------------------------------------------------------------------------= -- > > Key: THRIFT-4532 > URL: https://issues.apache.org/jira/browse/THRIFT-4532 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Affects Versions: 0.11.0 > Reporter: Bu=C4=9Fra Gedik > Priority: Minor > Fix For: 0.12.0 > > > We would like to contribute an improvement to the Thrift compiler that wo= uld avoid regenerating target file(s) if they are going to be exactly the s= ame as the ones already present in the same place. This will help when runn= ing the Thrift compiler in our build, especially in recursive mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)