From dev-return-52404-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Apr 6 15:11:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 38A88180675 for ; Fri, 6 Apr 2018 15:11:06 +0200 (CEST) Received: (qmail 82904 invoked by uid 500); 6 Apr 2018 13:11:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 82893 invoked by uid 99); 6 Apr 2018 13:11:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2018 13:11:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 686B0C0042 for ; Fri, 6 Apr 2018 13:11:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id bBKW-d3EUGhn for ; Fri, 6 Apr 2018 13:11:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 398ED5FB55 for ; Fri, 6 Apr 2018 13:11:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EA384E094F for ; Fri, 6 Apr 2018 13:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6187B2562C for ; Fri, 6 Apr 2018 13:11:00 +0000 (UTC) Date: Fri, 6 Apr 2018 13:11:00 +0000 (UTC) From: "James E. King, III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (THRIFT-3595) Perl Bindings: Set serialization/deserialization differs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-3595. -------------------------------------- Resolution: Unresolved > Perl Bindings: Set serialization/deserialization differs > -------------------------------------------------------- > > Key: THRIFT-3595 > URL: https://issues.apache.org/jira/browse/THRIFT-3595 > Project: Thrift > Issue Type: Bug > Components: Perl - Compiler > Affects Versions: 0.9.1, 0.9.2, 0.9.3 > Reporter: Adam Millerchip > Assignee: James E. King, III > Priority: Major > > In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the serialization code expects an arrayref. This causes the code to die when called if attempting to serialize a previously dezerialized Set. > Additionally, it looks like there is a typo in the test that is testing this feature: > https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262 > If you change that {{@$setout}} to {{@$setin}}, the test fails. > It doesn't make much sense to implement a Set in Perl as array, because arrays allow duplicate entries and are ordered. > I've written a change for the serialization that correctly expects a hashref: https://github.com/apache/thrift/pull/831 -- This message was sent by Atlassian JIRA (v7.6.3#76005)