thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4558) reserved Csharp keyword are not escaped when field is required
Date Tue, 17 Apr 2018 20:17:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jens Geyer updated THRIFT-4558:
-------------------------------
    Affects Version/s: 0.10.0
                       0.11.0

> reserved Csharp keyword are not escaped when field is required
> --------------------------------------------------------------
>
>                 Key: THRIFT-4558
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4558
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.9.3, 0.10.0, 0.11.0
>            Reporter: Pierre Mignolet
>            Assignee: Pierre Mignolet
>            Priority: Major
>             Fix For: 0.12.0
>
>
> {code:java}
> struct MeMessage {
>  1: optional string fixed
>  7: required string unchecked
> }{code}
> Here reserved fixed C# keyword is escaped via @ but unchecked is not escaped in C# code
so code is just not compilable
> ----
> I had a look in t_csharp_generator.cc and keyword are present and method normalize_name
should make the escape



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message