thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4548) Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python
Date Wed, 18 Apr 2018 02:49:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441808#comment-16441808
] 

ASF GitHub Bot commented on THRIFT-4548:
----------------------------------------

jeking3 commented on issue #1547: THRIFT-4548: python binary accelerated protocol with multiplexing
via decoration
URL: https://github.com/apache/thrift/pull/1547#issuecomment-382233558
 
 
   Very nice - I knew something was wrong when I had to disable that many tests as I added
multiplexed support to TestClient, so I'm really glad to see you figured it out and removed
the test exclusions!
   
   Test failures:  Appveyor:  Looks like oracle moved a download link and the chocolatey package
hasn't been updated yet.  Not relevant to this change.
   
   sca build failure:
   ```
   # Python code style
   flake8 --ignore=E501 --exclude=lib/py/build lib/py
   lib/py/src/protocol/TProtocolDecorator.py:23:41: E226 missing whitespace around arithmetic
operator
   lib/py/src/protocol/TProtocolDecorator.py:27:1: W391 blank line at end of file
   ```
   
   Recommend you run the flake8 commands in build/docker/scripts/sca.sh after making python
code changes to avoid that in the future.  We might even want to teach our regular make to
do this if it's fast.
   
   ubsan failure is an intermittent lisp compiler issue where it cannot find a temporary file
it just wrote - not relevant here.
   
   Cross test failure is real and related to the changes:
   ```
   *************************** client message ***************************
   Tue Apr 17 17:11:46 2018
   Executing: /thrift/src/test/py/TestClient.py --verbose --host=localhost --genpydir=gen-py
--protocol=multi --transport=framed --port=46135
   Directory: /thrift/src/test/py
   config:delay: 5
   config:timeout: 10
   ===============================================================================
   EEEEEEEEEEEEEEEEEEEEEE
   ======================================================================
   ERROR: testBinary (__main__.MultiplexedBinaryTest)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/thrift/src/test/py/TestClient.py", line 148, in testBinary
       self.assertEqual(bytearray(self.client.testBinary(bytes(val))), val)
     File "/thrift/src/test/py/gen-py/ThriftTest/ThriftTest.py", line 574, in testBinary
       self.send_testBinary(thing)
     File "/thrift/src/test/py/gen-py/ThriftTest/ThriftTest.py", line 578, in send_testBinary
       self._oprot.writeMessageBegin('testBinary', TMessageType.CALL, self._seqid)
     File "/thrift/src/lib/py/build/lib.linux-x86_64-2.7/thrift/protocol/TMultiplexedProtocol.py",
line 33, in writeMessageBegin
       super().writeMessageBegin(
   TypeError: super() takes at least 1 argument (0 given)
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python
> -----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4548
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4548
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Balazs Kemenes
>            Priority: Major
>
> Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message