thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4548) Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python
Date Tue, 17 Apr 2018 15:36:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441034#comment-16441034
] 

ASF GitHub Bot commented on THRIFT-4548:
----------------------------------------

nijm opened a new pull request #1547: THRIFT-4548: python binary accelerated protocol with
multiplexing via decoration
URL: https://github.com/apache/thrift/pull/1547
 
 
   THRIFT-4548: multiplexed (decorated) protocols inherit from TProtocolBase
   Client: py
   
   TMultiplexedProtocol objects did not inherit from TProtocolBase, so the decorated protocol
object passed into the binary accelerated C extension was not really a TProtocolBase object,
which caused errors. This implementation decorates the protocol object by dynamically creating
a new class that extends both the class of the protocol being decorated and TMultiplexedProtocol.
   
   I tested the changes locally. I had trouble running the full suite of cross tests, but
running the py,py3 cross tests worked, although I'm not sure these are testing multiplexed
protocols.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python
> -----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4548
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4548
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Balazs Kemenes
>            Priority: Major
>
> Supporting TBinaryProtocolAccelerated protocol when using TMultiplexedProcessor in Python



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message