thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Trinidad (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (THRIFT-4542) git.apache.org/thrift.git unavailable
Date Thu, 05 Apr 2018 15:18:04 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427087#comment-16427087
] 

Tim Trinidad edited comment on THRIFT-4542 at 4/5/18 3:17 PM:
--------------------------------------------------------------

For those using composer, we were able to point to github directly by adding the github location
to the {{repositories}} section of our {{composer.json}}:
{noformat}
}
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/apache/thrift.git"
        }
    ]
}
{noformat}

If your composer installation is failing due to an indirect dependency (i.e. your project
doesn't directly require {{apache/thrift}}), you can still add the repository above and directly
require it - this will force downstream dependencies to use version you installed from github.


was (Author: timtrinidad):
For those using compose, we were able to point to github directly by adding the github location
to the {{repositories}} section of our {{composer.json}}:
{noformat}
}
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/apache/thrift.git"
        }
    ]
}
{noformat}

If your composer installation is failing due to an indirect dependency (i.e. your project
doesn't directly require {{apache/thrift}}), you can still add the repository above and directly
require it - this will force downstream dependencies to use version you installed from github.

> git.apache.org/thrift.git unavailable
> -------------------------------------
>
>                 Key: THRIFT-4542
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4542
>             Project: Thrift
>          Issue Type: Bug
>          Components: Documentation, Go - Compiler, Go - Library, PHP - Library
>            Reporter: Brian Shannan
>            Priority: Critical
>
> https://issues.apache.org/jira/browse/INFRA-16287 appears to have moved the thrift repo
from git.apache.org/thrift.git to a new location, without leaving a copy of the repository
at the old location. This broke all the imports of thrift in go generated code, as it references
git.apache.org/thrift.git, as well as library code we have to interact with thrift. This can
be changed through a flag in the generator, but due to the nature of go all imports of thrift
have to be from the same url (otherwise the go compiler thinks they're different types), making
this a pain to upgrade across multiple codebases and instances of generated code.
>  
> A copy of the thrift repo at it's current state should be put back at git.apache.org
so existing go code would continue to work until consumers can switch imports to the new
repository



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message