thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4539) Allow TBufferedTransport to be used as base class
Date Sun, 01 Apr 2018 23:33:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421847#comment-16421847
] 

ASF GitHub Bot commented on THRIFT-4539:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1529

    THRIFT-4539 Allow TBufferedTransport to be used as base class

    Client: C#
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-4539

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1529
    
----
commit 4ab2f4a8d578608903d325f3149fcbbcd7575726
Author: Jens Geyer <jensg@...>
Date:   2018-04-01T23:30:22Z

    THRIFT-4539 Allow TBufferedTransport to be used as base class
    Client: C#
    Patch: Jens Geyer

----


> Allow TBufferedTransport to be used as base class
> -------------------------------------------------
>
>                 Key: THRIFT-4539
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4539
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>
> In the current form, {{TBufferedTransport}} cannot be used as base class, because there
is a potential endless recusrion when {{public override int Read(byte[] buf, int off, int
len)}} is overridden, because the inner function may call the outer again in an unexpected
way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message