thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed
Date Mon, 16 Apr 2018 02:34:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438932#comment-16438932
] 

ASF GitHub Bot commented on THRIFT-4532:
----------------------------------------

jeking3 commented on issue #1541: THRIFT-4532: Do not update previously generated output files
if the contents have not changed
URL: https://github.com/apache/thrift/pull/1541#issuecomment-381463350
 
 
   Was it truly necessary to change the signature of the methods from ostream to ofstream?
 After all, an ofstream *is an* ostream.  It should be possible to keep all the methods using
ostream which accepts your custom ofstream class that checks to see if the content changed.
   
   Extra nice to see a test for this, by the way, I like that a lot!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid updating Thrift compiler generated code if the output has not changed
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-4532
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4532
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.11.0
>            Reporter: Bu─čra Gedik
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> We would like to contribute an improvement to the Thrift compiler that would avoid regenerating
target file(s) if they are going to be exactly the same as the ones already present in the
same place. This will help when running the Thrift compiler in our build, especially in recursive
mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message