thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vihang Karajgaonkar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268
Date Sat, 28 Apr 2018 00:35:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457260#comment-16457260
] 

Vihang Karajgaonkar commented on THRIFT-3769:
---------------------------------------------

ping [~jking3] 

> Fix logic of THRIFT-2268
> ------------------------
>
>                 Key: THRIFT-3769
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3769
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9.2
>            Reporter: Harsh J
>            Priority: Minor
>         Attachments: THRIFT-3769.patch
>
>
> THRIFT-2268 intended to reduce the logging noise of TSaslTransport enabled servers, but
the commit doesn't help in doing so (its just adding more specific noise today).
> This is because the transport factory overrides disallow throwing specific execution
types (no TTransportException in signature), and thereby all implementations will throw a
RuntimeException-wrapped exception, which the added catch clauses would never encounter.
> https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/transport/TSaslServerTransport.java#L217-L219
> https://github.com/apache/thrift/blob/master/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java#L290-L295
> We'll need to unwrap the RuntimeException to perform an actual valid cause check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message