From dev-return-52243-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Mar 30 14:55:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9A0E1180647 for ; Fri, 30 Mar 2018 14:55:07 +0200 (CEST) Received: (qmail 97208 invoked by uid 500); 30 Mar 2018 12:55:06 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 97197 invoked by uid 99); 30 Mar 2018 12:55:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2018 12:55:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2A1F3C0042 for ; Fri, 30 Mar 2018 12:55:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ICZKKgryUYou for ; Fri, 30 Mar 2018 12:55:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9B6EC5F503 for ; Fri, 30 Mar 2018 12:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB36DE00C9 for ; Fri, 30 Mar 2018 12:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 352B2255ED for ; Fri, 30 Mar 2018 12:55:00 +0000 (UTC) Date: Fri, 30 Mar 2018 12:55:00 +0000 (UTC) From: "Christian Weiss (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4535?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 20458#comment-16420458 ]=20 Christian Weiss commented on THRIFT-4535: ----------------------------------------- {quote}As long as we can have a single set of project files that will work = both for, let's say, Visual Studio 2015 OR for dotnet core 2.0 (msbuild) on= linux or windows, then okay.=C2=A0 If the project files are incompatible, = they should probably remain separate. {quote} With the new project format, it's possible to do everything in one project = file. See e.g.=C2=A0[Newtonsoft.Json|https://github.com/JamesNK/Newtonsoft.= Json/blob/master/Src/Newtonsoft.Json/Newtonsoft.Json.csproj] which supports= pretty much every platform there is. The only requirement for this is that= developers who want to contribute need Visual Studio 2017 (the free versio= n is enough), Visual Studio Code or Visual Studio for Mac. I don't know your user base but supporting .NET 4.5+ and .NET Core seems li= ke what most projects are doing right now. As [~jking3] said, people can al= ways stay on an older version if they are still working on Silverlight, Win= dows Phone or .NET 3.5. Given that there's a tag/branch for the last releas= e you could also always create a patch-release for the old version if there= is a critical problem. I'd be happy to do some work, but you need to agree on what code base shoul= d be used as the base. * Should I work on "csharp" and "modernize" it by taking stuff from "netco= re"? Has this already been tried and failed, resulting in the decision to c= reate the new, distinct, "netcore" code base? * Should I work on "netcore" and add missing features from "csharp" (if th= ere are any) and make it support more platforms (it currently only supports= .NET Standard 2.0). Releasing this will result in whatever breaking change= s there are between these APIs. > Current state and future of .NET libraries ("csharp" and "netcore")? > -------------------------------------------------------------------- > > Key: THRIFT-4535 > URL: https://issues.apache.org/jira/browse/THRIFT-4535 > Project: Thrift > Issue Type: Question > Components: C# - Library, netcore - Library > Reporter: Christian Weiss > Priority: Major > > Hi, > We are trying to use Thrift in one of our projects but we ran into some v= ery fundamental issues: > * The "csharp" project does not target ".NET Standard" and there's only = a very old release on nuget.org ( if [https://www.nuget.org/packages/Thrift= /]=C2=A0is the official one). > * The "netcore" project does target ".NET Standard" but there's no relea= se yet (=C2=A0https://issues.apache.org/jira/browse/THRIFT-4512=C2=A0)=C2= =A0and it also has a dependency on ASP.NET Core ( https://issues.apache.org= /jira/browse/THRIFT-4534=C2=A0) which makes it unusable in non-web projects= . > I'm wondering why there even are 2 separate projects for .NET? It's impor= tant to understand that ".NET Core" is not a new programming API - It's jus= t a new platform - very similar to Silverlight, Mono, Windows Phone. This m= eans that it=C2=A0would also be possible to support=C2=A0.NET Core and the = new ".NET Standard" (which represents a common set of APIs for all platform= s) with the existing "csharp" project.=C2=A0 > Was this a deliberate decision - e.g. to make the "netcore" code the offi= cial successor of the "csharp" code?=C2=A0 > Would you be interested in=C2=A0merging the code back into one library?= =C2=A0I'd be willing to help if you want! > It would be great to get one proper, up to date and official .NET library= soon as there's already quite a lot of weird forks on NuGet.org:=C2=A0http= s://www.nuget.org/packages?q=3DThrift=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)