From dev-return-51919-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Mar 15 16:53:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1F84B180654 for ; Thu, 15 Mar 2018 16:53:04 +0100 (CET) Received: (qmail 3471 invoked by uid 500); 15 Mar 2018 15:53:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 3460 invoked by uid 99); 15 Mar 2018 15:53:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2018 15:53:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 800CEC0582 for ; Thu, 15 Mar 2018 15:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.811 X-Spam-Level: X-Spam-Status: No, score=-109.811 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5KCyoKZgAFPr for ; Thu, 15 Mar 2018 15:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D6BFE5F635 for ; Thu, 15 Mar 2018 15:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 578D9E0446 for ; Thu, 15 Mar 2018 15:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EC48621495 for ; Thu, 15 Mar 2018 15:53:00 +0000 (UTC) Date: Thu, 15 Mar 2018 15:53:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4516) Add support for go 1.10 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4516?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D164= 00598#comment-16400598 ]=20 ASF GitHub Bot commented on THRIFT-4516: ---------------------------------------- Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1507 =20 Failures seem unrelated. Should I merge or do you need to something on = docker.io? > Add support for go 1.10 > ----------------------- > > Key: THRIFT-4516 > URL: https://issues.apache.org/jira/browse/THRIFT-4516 > Project: Thrift > Issue Type: Improvement > Components: Go - Library > Affects Versions: 0.11.0 > Environment: ubuntu-artful (using go 1.10 instead of 1.9) > Reporter: James E. King, III > Assignee: Can Celasun > Priority: Major > > Currently go 1.10 has additional type checking on format strings that pre= vent thrift from compiling and running tests.=C2=A0 We are limited to go 1.= 9 until this is resolved. > Example: > {noformat} > thrift/protocol_test.go:442: Errorf format %s has arg thelen of wrong typ= e int > thrift/protocol_test.go:447: Errorf format %q has arg v of wrong type flo= at64 > thrift/protocol_test.go:451: Errorf format %q has arg v of wrong type flo= at64 > thrift/protocol_test.go:454: Errorf format %q has arg value of wrong type= float64 > thrift/protocol_test.go:482: Errorf format %s has arg thelen of wrong typ= e int > thrift/protocol_test.go:491: Errorf format %d has arg v of wrong type str= ing > gopath/src/dontexportrwtest/compile_test.go:32: Sprintf format %v arg s.r= ead is a func value, not called > gopath/src/dontexportrwtest/compile_test.go:33: Sprintf format %v arg s.w= rite is a func value, not called > gopath/src/dontexportrwtest/compile_test.go:36: Sprintf format %v arg is.= read is a func value, not called > gopath/src/dontexportrwtest/compile_test.go:37: Sprintf format %v arg is.= write is a func value, not called{noformat} > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)