thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4524) .NET Core Server doesn't close properly when cancelled
Date Tue, 20 Mar 2018 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406974#comment-16406974
] 

ASF GitHub Bot commented on THRIFT-4524:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1512


> .NET Core Server doesn't close properly when cancelled
> ------------------------------------------------------
>
>                 Key: THRIFT-4524
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4524
>             Project: Thrift
>          Issue Type: Bug
>          Components: .NETCore - Library
>    Affects Versions: 0.11.0
>         Environment: Windows 10 Surface Pro 4. Xamarin.Forms app.  .NET Standard 2.0
libraries.
>            Reporter: Stephen Starkie
>            Assignee: James E. King, III
>            Priority: Major
>             Fix For: 0.12.0
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> My code starts a server with a cancellation token and then later stops it by triggering
the token.  When it does, the server fails to close cleanly and my code cannot then start
another server on the same port.  The problem is that the Task which is responsible for opening
and closing the connection in AsyncBaseServer throws a TokenCancelationException in the Task.Delay
call which is not caught and therefore bombs out the task without closing the socket.  I
will raise a pull request with a fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message