thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client
Date Tue, 20 Mar 2018 19:27:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406890#comment-16406890
] 

ASF GitHub Bot commented on THRIFT-4489:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1491
  
    This squash was not done properly.  It includes all of the master commits in it.
    
    You want to start with an updated master:
    
    git checkout master
    git pull
    
    Then you want to branch:
    git checkout -b THRIFT-4489-squashed
    
    Then you want to merge with squash, pulling anything in uds-nodejs over to THRIFT-4489-squashed
    git merge --squash uds-nodejs
    
    Then commit and add your description for your changes.
    Then push that branch and let me know when it is in your fork, and I will pull it and
merge it.  No need to update this PR or open a new one.



> Unix domain socket support for NodeJS client
> --------------------------------------------
>
>                 Key: THRIFT-4489
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4489
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.11.0
>            Reporter: Daniel Shih
>            Assignee: James E. King, III
>            Priority: Major
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message